Skip to content

ENH: fake http proxy in case of --skip-network testing #19757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2018
Merged

ENH: fake http proxy in case of --skip-network testing #19757

merged 3 commits into from
Feb 19, 2018

Conversation

yarikoptic
Copy link
Contributor

@yarikoptic
Copy link
Contributor Author

yarikoptic commented Feb 19, 2018 •
edited
Loading

hm, travis passed - a bad sign sing #19754 was not yet merged so I expected tests to fail :-/
answer: ah -- that was only script_single, doing that to multi now as well

@codecov
Copy link

codecov bot commented Feb 19, 2018 •
edited
Loading

Codecov Report

Merging #19757 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19757   +/-   ##
=======================================
  Coverage    91.6%    91.6%           
=======================================
  Files         150      150           
  Lines       48864    48864           
=======================================
  Hits        44763    44763           
  Misses       4101     4101
Flag Coverage Δ
#multiple 89.98% <ø> (ø) ⬆️
#single 41.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df5ab7...936b1cb. Read the comment docs.

@yarikoptic
Copy link
Contributor Author

ok, it failed, will merge #19754 to see if it resolves it

@yarikoptic yarikoptic mentioned this pull request Feb 19, 2018
Closed
1 task
@jreback jreback added the IO Network Local or Cloud (AWS, GCS, etc.) IO Issues label Feb 19, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 19, 2018
@jreback jreback merged commit c1f0c63 into pandas-dev:master Feb 19, 2018
@jreback
Copy link
Contributor

jreback commented Feb 19, 2018

thanks @yarikoptic

@yarikoptic yarikoptic deleted the enh-no-network-enforced branch February 20, 2018 22:35
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
@yarikoptic
ENH: fake http proxy in case of --skip-network testing (pandas-dev#19757
15232fd 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO Network Local or Cloud (AWS, GCS, etc.) IO Issues
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yarikoptic @jreback